I was reviewing the most-excellent MR and noticed that in 1.2 upgrade installation path, down along line #508 we add the CONSTRAINT ckRebuildGTReorg with
ALTER TABLE Minion.IndexSettingsDB ADD CONSTRAINT
ckRebuildGTReorg CHECK (([RebuildThreshold]>[ReorgThreshold]))
but by line #511 (where we COMMIT), we haven't actually checked the new CONSTRAINT, so it wouldn't be a trusted constraint. Shouldn't we before the COMMIT do this?
ALTER TABLE Minion.IndexSettingsDB CHECK CONSTRAINT ckRebuildGTReorg
Thanks for letting us know. We’re taking a look at this for the next service release.